Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List archived workflows CLI #391

Merged
merged 24 commits into from May 23, 2019

Conversation

@melvl01
Copy link
Contributor

commented May 17, 2019

Add List Archived Worklfows CLI, based on API.
User can use this operation to list the archived z/OSMF workflows for a system or sysplex.
I added also in my code changes from pull request #388 - List atchived wf api enhance

melvl01 added some commits Apr 12, 2019

Add CLI for List Archived Workflows command
Signed-off-by: melvl01 <melvl01@ca.com>
Add system tests CLI for List Archived Workflows
Signed-off-by: melvl01 <melvl01@ca.com>
Polishing of examples
Signed-off-by: melvl01 <melvl01@ca.com>
Updated snapshoots + added flag asc or desc
Signed-off-by: melvl01 <melvl01@ca.com>
Updated handler with asc/desc flag
Signed-off-by: melvl01 <melvl01@ca.com>
Trying fixed List Archived API and its unit tests
Signed-off-by: melvl01 <melvl01@ca.com>
Added one more constant to WfConstant.ts
Signed-off-by: melvl01 <melvl01@ca.com>
Clean up, to use List only with WorkflowKey
Signed-off-by: melvl01 <melvl01@ca.com>
Clean up, to use List only with WorkflowKey
Signed-off-by: melvl01 <melvl01@ca.com>
Clean up, to use List only with WorkflowKey
Signed-off-by: melvl01 <melvl01@ca.com>
Clean up, to use List only with WorkflowKey
Signed-off-by: melvl01 <melvl01@ca.com>
List just all workflows, no options
Signed-off-by: melvl01 <melvl01@ca.com>
Fixed CLI for List Archived + tests
Signed-off-by: melvl01 <melvl01@ca.com>

@melvl01 melvl01 closed this May 17, 2019

@melvl01 melvl01 reopened this May 20, 2019

melvl01 added some commits May 20, 2019

add skipProperties option to integration test
Signed-off-by: melvl01 <melvl01@ca.com>
updated snapshot for integration test
Signed-off-by: melvl01 <melvl01@ca.com>
import { ListArchivedWorkflows } from "../../../../src/api/ListArchivedWorkflows";


describe("Delete workflow common handler", () => {

This comment has been minimized.

Copy link
@uzust01

uzust01 May 20, 2019

Contributor

Archive instead of Delete

This comment has been minimized.

Copy link
@melvl01

melvl01 May 20, 2019

Author Contributor

Thanks, fixed


describe("Delete workflow common handler", () => {
describe("process method", () => {
it("should delete a workflow using workflow name", async () => {

This comment has been minimized.

Copy link
@uzust01

uzust01 May 20, 2019

Contributor

Archive instead of Delete

This comment has been minimized.

Copy link
@melvl01

melvl01 May 20, 2019

Author Contributor

Done

melvl01 added some commits May 20, 2019

fixing typos
Signed-off-by: melvl01 <melvl01@ca.com>
updated snapshot after fixing typos
Signed-off-by: melvl01 <melvl01@ca.com>
@ChrisBoehmCA

This comment has been minimized.

Copy link
Contributor

commented May 20, 2019

System tests passed for me. Just had one small request. Please open a PR for master as well

melvl01 added some commits May 22, 2019

resolve one comment from Chris
Signed-off-by: melvl01 <melvl01@ca.com>
fixed "magic number"
Signed-off-by: melvl01 <melvl01@ca.com>
@ChrisBoehmCA
Copy link
Contributor

left a comment

Thanks for making the changes.

zFernand0 added a commit that referenced this pull request May 23, 2019

Merge pull request #397 from melvl01/master
Port changes from #391 to master

@zFernand0 zFernand0 merged commit 70db784 into zowe:lts-incremental May 23, 2019

1 of 2 checks passed

continuous-integration/jenkins/pr-merge This commit cannot be built
Details
DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.