Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dataset eof bug #40

Merged
merged 3 commits into from Jun 17, 2019

Conversation

@chcaron01
Copy link

commented Jun 5, 2019

While reading in lines from the dataset, the function streamDataset() did not check if an entry was of size 0 (indicating end of file). By adding a conditional check, the extra blank line is no longer printed.

Charlie Caron added some commits Jun 5, 2019

Charlie Caron
Fixed dataset eof bug.
Signed-off-by: Charlie Caron <ccaron@rocketsoftware.com>
Charlie Caron
Fixed dataset eof bug
Signed-off-by: Charlie Caron <ccaron@rocketsoftware.com>
@chcaron01

This comment has been minimized.

Copy link
Author

commented Jun 5, 2019

@jordanfilteau1995

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2019

Hi @1000TurquoisePogs,

I saw the demo of these changes in person. It fixes the problem. I don't see anything wrong with it besides that we need to eventually migrate all the printf to zowelog, which is out of scope. I had him try a few different kinds of datasets. Do you see any issues with this? You know this API much better than I do.

}
fclose(in);
else if (bytesRead == 0){
printf("Reached end of dataset\n");

This comment has been minimized.

Copy link
@1000TurquoisePogs

1000TurquoisePogs Jun 14, 2019

Contributor

Since we didn't use any way to differentiate between debug & non debug messages, please remove this printf entirely. It is meaningless to the end user and they will see zillions of them.

This comment has been minimized.

Copy link
@chcaron01

chcaron01 Jun 17, 2019

Author

I've updated this in the latest commit

Charlie Caron
Removed useless print statement
Signed-off-by: Charlie Caron <ccaron@rocketsoftware.com>

@chcaron01 chcaron01 force-pushed the chcaron01:dataset_eof_bug branch from 0034ff1 to 4e1efbc Jun 17, 2019

@1000TurquoisePogs 1000TurquoisePogs merged commit d12268e into zowe:staging Jun 17, 2019

1 check passed

DCO DCO
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.