Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix forbidden returns 200 OK #44

Conversation

@elizabethkirschner
Copy link

commented Jun 7, 2019

Calling get on a directory the user does not have permission for returns the correct status and error message.

Signed-off-by: E Kirschner ekirschner@rocketsoftware.com

E Kirschner
Fixed returns staus 200 OK on directories user does not have permissi…
…on for

Signed-off-by: E Kirschner <ekirschner@rocketsoftware.com>
@elizabethkirschner

This comment has been minimized.

Copy link
Author

commented Jun 7, 2019

@1000TurquoisePogs 1000TurquoisePogs requested a review from Jun 18, 2019

@1000TurquoisePogs 1000TurquoisePogs merged commit b44421a into zowe:staging Jun 18, 2019

1 check passed

DCO DCO
Details
@ifakhrutdinov
Copy link
Contributor

left a comment

@elizabethkirschner, @1000TurquoisePogs, I think this PR introduces a bug. See my comment.

}
makeHTMLForDirectory(response, absolutePath, parsedFileTail->string,TRUE);

if (directory = (directoryOpen(absolutePath,&returnCode,&reasonCode)) == NULL){

This comment has been minimized.

Copy link
@ifakhrutdinov

ifakhrutdinov Jun 19, 2019

Contributor
  • This produces a warning message
[exec] WARNING CCN3068 /u/tsirf/zowe-secmgmt/zowe-common-c/c/httpserver.c:3774  Operation between types "struct UnixFileStream_tag*" and "int" is not allowed.
  • The if condition seems to have a bug - first we compare the result of dorectoryOpen with NULL and then assign the result (either 1 or 0 depending on the result) to directory. I think you meant the following:
if ((directory = directoryOpen(absolutePath,&returnCode,&reasonCode)) == NULL){
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.