Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unix file/directory response info for use in Editor #93

Merged

Conversation

@DivergentEuropeans
Copy link
Contributor

DivergentEuropeans commented Oct 9, 2019

  • Reorganized logic to use boolean better and changed a 500 to a 400 to better differentiate a probable permission problem from a general server error.
  • Addressed comments & suggestions
  • Fixed sign off

PR 1 of 2
PR 2 zowe/zowe-common-c#89

Signed-off-by: Leanid Astrakou lastrakou@rocketsoftware.com

Copy link
Member

1000TurquoisePogs left a comment

Agree with this due to it being just an application of zowe/zowe-common-c#89

@ifakhrutdinov

This comment was marked as resolved.

Copy link
Contributor

ifakhrutdinov commented Oct 10, 2019

@DivergentEuropeans please see my comments in the zowe-common-c PR,

Please also fix your sign-off-by comment.

Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans force-pushed the DivergentEuropeans:file-directory-responses branch from 50ad156 to 1ee3835 Oct 10, 2019
c/unixFileService.c Outdated Show resolved Hide resolved
c/unixFileService.c Outdated Show resolved Hide resolved
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou added 2 commits Oct 15, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
c/unixFileService.c Outdated Show resolved Hide resolved
@ifakhrutdinov

This comment was marked as resolved.

Copy link
Contributor

ifakhrutdinov commented Oct 16, 2019

@DivergentEuropeans Can you please also update the zowe-common-c submodule with the zowe commit you need (zowe/zowe-common-c@fff6bc6), right now it point to a commit from your fork (DivergentEuropeans/zowe-common-c@dd93d1c).

Leanid Astrakou added 2 commits Oct 16, 2019
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
c/unixFileService.c Outdated Show resolved Hide resolved
c/unixFileService.c Outdated Show resolved Hide resolved
c/unixFileService.c Outdated Show resolved Hide resolved
c/unixFileService.c Outdated Show resolved Hide resolved
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans force-pushed the DivergentEuropeans:file-directory-responses branch from 6466406 to 0c7a296 Oct 22, 2019
Leanid Astrakou
Signed-off-by: Leanid Astrakou <lastrakou@rocketsoftware.com>
@DivergentEuropeans DivergentEuropeans force-pushed the DivergentEuropeans:file-directory-responses branch from 0c7a296 to c69eee7 Oct 22, 2019
@ifakhrutdinov ifakhrutdinov merged commit 041bba2 into zowe:staging Oct 23, 2019
2 checks passed
2 checks passed
DCO DCO
Details
continuous-integration/jenkins/pr-merge This commit looks good
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.