Update login.ztml - #106
Merged
Merged
Conversation
XSS fixes. If form action is empty, the target is self script. PHP_SELF not needed.
Contributor
|
This was previously added to ensure legacy browser support but I guess as the latest theme is using a whole load of jQuery and HTML5 I guess we could remove the attribute value for no other reason but to remove a few characters from the login template. |
allebb
added a commit
that referenced
this pull request
Feb 10, 2014
Removal of FORM POST URL (use of PHP_SELF constant) as not required (code clean-up).
Contributor
Author
|
I think other little reason could be XSS patch as I said, if you don't sanitize PHP_SELF and you try something like /index.php/%22%3E%3Cscript%3Ealert%28document.cookie%29%3C%2fscript%3E you will get nice javascript alert. |
Contributor
|
(only for note) Since HTML5, action="" is reported as an error by html validator (http://validator.w3.org/). when empty, the directive "action" should be completely removed. |
Contributor
|
Cheers 5050, I'll remove the attribute altogether 👍 |
Contributor
|
Fixed: a8a540d - Good call there 5050! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
XSS fixes.
If form action is empty, the target is self script. PHP_SELF not needed.