New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logo to qrcode #7
Conversation
Can you explain why you want this and show me a screenshot of this in action? |
+1 |
@zpao @cssivision @zpao Are you interested in having this feature? From what I can see the only thing that's missing now is the |
@zpao Would love to include this feature in master! Embedding a vendor logo in a QRcode is a common practice in China. When customers see a known/verified logo, they are more willing to scan the QRCode. Below is an example of with a Alipay (the largest online and mobile payment platform in China) logo. |
+1 definitely good idea! |
It's been a long time since I've commented. I've been working on adding this but in a way that maximizes image size without impacting the error correction of the qr code and without covering the essential components (dark module, finder patterns). Maybe that's overkill and just covering max N% is enough. |
Why this PR is not merge to master @zpao? |
Is there any chance that this is going to be added in the future? |
Going to finally close this out as I have an implementation that is what I want to ship in #81. Apologies for the super long delay in making this feature happen. |
@zpao : When will you publish the new version to add the logo? |
I shipped a new version last week. |
add logo to qrcode, just add image url.