Skip to content

Commit

Permalink
Don't report success/failure for ignored tests.
Browse files Browse the repository at this point in the history
  • Loading branch information
robarnold committed Jun 3, 2011
1 parent 20eab77 commit fb70d24
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions reporter.js
Expand Up @@ -32,12 +32,16 @@ var successes = [

exports.success = function success(cb, event)
{
if (event.ignored)
return;
var text = randompicker(successes, 'text');
cb(text);
}

exports.warning = function warning(cb, event)
{
if (event.ignored)
return;
shorturl(event.logfile, kUrlService, function (logfile) {
committers.lookup(event.pusher, function (name) {
cb("{0}: I see test failures in {1} on {2} with your push of {3} to {4}. Details: {5}", name, event.type, event.platform, event.rev, event.tree, logfile);
Expand All @@ -53,6 +57,8 @@ exports.warning = function warning(cb, event)

exports.failure = function failure(cb, event)
{
if (event.ignored)
return;
shorturl(event.logfile, kUrlService, function (logfile) {
committers.lookup(event.pusher, function (name) {
cb("{0}: Did you try compiling before pushing to {3}? There's a build failure on {1}, see {2} for details", name, event.platform, logfile, event.tree);
Expand Down

0 comments on commit fb70d24

Please sign in to comment.