Permalink
Browse files

Move Page.click to FrameBase.click

The page function is just a shortcut for click on the main frame.
We weren't previously binding to this function for frames.
Both Page and Frame inherit this from FrameBase.
  • Loading branch information...
zploskey committed Jun 8, 2018
1 parent b51d472 commit 3433ed8ef68c0e7440b3bc2e47e15e8d556ab718
Showing with 5 additions and 5 deletions.
  1. +5 −0 src/FrameBase.re
  2. +0 −5 src/Page.re
@@ -391,6 +391,11 @@ external evaluateHandlePromise4 :
external evaluateStringHandle : string => Js.Promise.t(JSHandle.t) =
"evaluateHandle";

[@bs.send.pipe: t]
external click :
(string, ~options: Click.clickOptions=?, unit) => Js.Promise.t(unit) =
"";

/**
* Fetches the first element matching `selector`, scrolls it into view if not
* already visible, then hovers over the center of the element using
@@ -146,11 +146,6 @@ external bringToFront : t => Js.Promise.t(unit) = "";

[@bs.send] external browser : t => Types.browser = "";

[@bs.send.pipe: t]
external click :
(string, ~options: Click.clickOptions=?, unit) => Js.Promise.t(unit) =
"";

type closeOptions = {. "runBeforeUnload": Js.nullable(bool)};

[@bs.obj]

0 comments on commit 3433ed8

Please sign in to comment.