Permalink
Browse files

deviceScaleFactor should be a float

I tested this with `--force-device-scale-factor=0.5` and it created
a tiny window.
  • Loading branch information...
zploskey committed Jun 8, 2018
1 parent 6f1b218 commit 3b109ace50a1d352eb9f85d19243a738ad69c574
Showing with 4 additions and 3 deletions.
  1. +2 −2 __tests__/puppeteer_test.re
  2. +2 −1 src/Page.re
@@ -450,7 +450,7 @@ describe("Page", () => {
"viewport": {
"width": 320,
"height": 480,
"deviceScaleFactor": 2,
"deviceScaleFactor": 2.,
"isMobile": true,
"hasTouch": true,
"isLandscape": true,
@@ -464,7 +464,7 @@ describe("Page", () => {
|> ExpectJs.toMatchObject({
"width": 320,
"height": 480,
"deviceScaleFactor": 2,
"deviceScaleFactor": 2.,
"isMobile": true,
"hasTouch": true,
"isLandscape": true,
@@ -40,7 +40,7 @@ type viewport = {
.
"width": int,
"height": int,
"deviceScaleFactor": int,
"deviceScaleFactor": float,
"isMobile": bool,
"hasTouch": bool,
"isLandscape": bool,
@@ -162,6 +162,7 @@ external close : (~options: closeOptions=?) => Js.Promise.t(unit) = "";
external evaluateOnNewDocument : (unit => unit) => Js.Promise.t(unit) = "";

/* TODO: exposeFunction */

[@bs.send.pipe: t]
external focus : (~selector: string) => Js.Promise.t(unit) = "";

0 comments on commit 3b109ac

Please sign in to comment.