pdfOptions##scale should be a float

Fractional scales are OK.
zploskey · Jun 8, 2018 · 49904399e916fe1cd62bcb16fb7705b6da458127 · 4990439
1 parent 5d728a4
commit 49904399e916fe1cd62bcb16fb7705b6da458127
Unified Split

Showing with 3 additions and 3 deletions.

+1 −1 __tests__/puppeteer_test.re

+2 −2 src/Page.re
diff --git a/__tests__/puppeteer_test.re b/__tests__/puppeteer_test.re
@@ -566,7 +566,7 @@ describe("Page", () => {
      page^
      |> Page.pdf(
           Page.makePDFOptions(
-  
-             ~scale=1,
+  
+             ~scale=1.,
             ~displayHeaderFooter=true,
             ~headerTemplate="[[header]]",
             ~footerTemplate="[[footer]]",

diff --git a/src/Page.re b/src/Page.re
@@ -63,7 +63,7 @@ type margin = {
 type pdfOptions = {
  .
  "path": Js.undefined(string),
-  
-  "scale": Js.undefined(int),
+  
+  "scale": Js.undefined(float),
  "displayHeaderFooter": Js.undefined(bool),
  "headerTemplate": Js.undefined(string),
  "footerTemplate": Js.undefined(string),
@@ -109,7 +109,7 @@ external makeMargin :
 external makePDFOptions :
  (
    ~path: string=?,
-  
-    ~scale: int=?,
+  
+    ~scale: float=?,
    ~displayHeaderFooter: bool=?,
    ~headerTemplate: string=?,
    ~footerTemplate: string=?,