Permalink
Browse files

pdfOptions##scale should be a float

Fractional scales are OK.
  • Loading branch information...
zploskey committed Jun 8, 2018
1 parent 5d728a4 commit 49904399e916fe1cd62bcb16fb7705b6da458127
Showing with 3 additions and 3 deletions.
  1. +1 −1 __tests__/puppeteer_test.re
  2. +2 −2 src/Page.re
@@ -566,7 +566,7 @@ describe("Page", () => {
page^
|> Page.pdf(
Page.makePDFOptions(
~scale=1,
~scale=1.,
~displayHeaderFooter=true,
~headerTemplate="[[header]]",
~footerTemplate="[[footer]]",
@@ -63,7 +63,7 @@ type margin = {
type pdfOptions = {
.
"path": Js.undefined(string),
"scale": Js.undefined(int),
"scale": Js.undefined(float),
"displayHeaderFooter": Js.undefined(bool),
"headerTemplate": Js.undefined(string),
"footerTemplate": Js.undefined(string),
@@ -109,7 +109,7 @@ external makeMargin :
external makePDFOptions :
(
~path: string=?,
~scale: int=?,
~scale: float=?,
~displayHeaderFooter: bool=?,
~headerTemplate: string=?,
~footerTemplate: string=?,

0 comments on commit 4990439

Please sign in to comment.