Move Page.url() to FrameBase

zploskey · Jun 8, 2018 · 751bfc85eafd779583b70ebd789b1c9a555261f3 · 751bfc8
1 parent 840364d
commit 751bfc85eafd779583b70ebd789b1c9a555261f3
Unified Split

Showing with 6 additions and 2 deletions.

+4 −0 src/FrameBase.re

+2 −2 src/Page.re
diff --git a/src/FrameBase.re b/src/FrameBase.re
@@ -48,6 +48,8 @@ external makeSelectorOptions :
  selectorOptions =
  "";
+  
+/* TODO: waitForFunction */
+  
+
 [@bs.send.pipe: t]
 external waitForSelector :
  (string, ~options: selectorOptions=?, unit) => Js.Promise.t(unit) =
@@ -428,3 +430,5 @@ type typeOptions = {. "delay": float};
 external type_ :
  (string, string, ~options: typeOptions=?, unit) => Js.Promise.t(unit) =
  "type";
+  
+
+  
+[@bs.send] external url : t => string = "";
diff --git a/src/Page.re b/src/Page.re
@@ -311,9 +311,9 @@ external setViewport : (~viewport: viewport) => Js.Promise.t(unit) = "";
 [@bs.get] external tracing : t => Tracing.t = "";
-  
-[@bs.send] external url : t => string = "";
-  
-
 [@bs.send.pipe: t]
 external waitForNavigation :
  (~options: Navigation.options) => Js.Promise.t(Response.t) =
  "";
+  
+
+  
+/* TODO: workers() */