New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add JSHandle and more ElementHandle bindings #15

Merged
merged 7 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@zploskey
Copy link
Owner

zploskey commented Feb 28, 2018

ElementHandle extends JSHandle, so this separates the modules and adds some more bindings.

@zploskey zploskey requested a review from jihchi Feb 28, 2018

@zploskey

This comment has been minimized.

Copy link
Owner Author

zploskey commented Feb 28, 2018

All bindings that are still missing from these two modules are marked with TODOs. That's basically just the $, $$, and $x selectors and executionContext() which returns a type from a module we haven't tackled yet.


/* TODO: executionContext */

[@bs.send] external getProperties : t => Js.Promise.t(Js.Dict.t(t)) = "";

This comment has been minimized.

@zploskey

zploskey Feb 28, 2018

Author Owner

This returns an ES6 Map. This definitely needs a test just to see if treating it as a dict works.

This comment has been minimized.

@zploskey

zploskey Mar 1, 2018

Author Owner

In fact treating it like Dict does not work. Wound up wrapping the Map collection.

@jihchi

jihchi approved these changes Mar 1, 2018

Copy link
Collaborator

jihchi left a comment

LGTM

@zploskey zploskey merged commit 0400edd into master Mar 1, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the handling branch Mar 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment