New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing keys "env" and "devtools" to launchOptions #27

Merged
merged 2 commits into from Mar 12, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented Mar 12, 2018

The type launchOptions was missing "env" and "devtools" keys that were already present in the make function. Also properly types "env" as a Js.Dict.t(string).

zploskey added some commits Mar 12, 2018

Add env and devtools to launchOptions objects
Also properly types env as a dict of strings.
Removes a bunch of comments inside the type. These should
probably be explained in a doc comment on the make function?
Leave them out for now.

@zploskey zploskey merged commit 588b4d6 into master Mar 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the launchOptionsFixes branch Mar 12, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment