New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add binding for ElementHandle.contentFrame #34

Merged
merged 5 commits into from Mar 16, 2018

Conversation

Projects
None yet
2 participants
@jihchi
Copy link
Collaborator

jihchi commented Mar 14, 2018

Fix #23

it works with puppeteer@next.

@@ -17,7 +20,7 @@ external selectAll : (~selector: string) => Js.Promise.t(array(t)) = "$$";
external selectXPath : (~xpath: string) => Js.Promise.t(array(t)) = "$x";

[@bs.send.pipe: t]
external boundingBox : Js.Promise.t(Js.null(BoundingBox.t)) = "";
external boundingBox : Js.Promise.t(Js.Nullable.t(BoundingBox.t)) = "";

This comment has been minimized.

@zploskey

zploskey Mar 14, 2018

Owner

Unless for some reason this could be undefined it should be Js.null.

This comment has been minimized.

@jihchi

jihchi Mar 15, 2018

Author Collaborator

Reverted in commit 51cb1c3

@@ -14,7 +14,7 @@ external makeTagOptions :

[@bs.send.pipe: t]
external selectOne :
(~selector: string) => Js.Promise.t(Js.null(ElementHandle.t)) =
(~selector: string) => Js.Promise.t(Js.Nullable.t(ElementHandle.t)) =

This comment has been minimized.

@zploskey

zploskey Mar 14, 2018

Owner

Same as above.

This comment has been minimized.

@jihchi

jihchi Mar 15, 2018

Author Collaborator

Reverted in commit 51cb1c3

This comment has been minimized.

@jihchi

jihchi Mar 15, 2018

Author Collaborator

Reverted in commit 728c30d

@@ -49,3 +52,6 @@ external type_ :

[@bs.send.pipe: t] [@bs.splice]
external uploadFile : (~filePaths: array(string)) => Js.Promise.t(unit) = "";

[@bs.send.pipe: t]
external contentFrame : Js.Promise.t(Js.Nullable.t(Types.frameBase)) = "";

This comment has been minimized.

@zploskey

zploskey Mar 14, 2018

Owner

Should likely also be Js.null. We can use Js.nullToOption etc.

This comment has been minimized.

@jihchi

jihchi Mar 15, 2018

Author Collaborator

Fixed in commit 51cb1c3

@zploskey

This comment has been minimized.

Copy link
Owner

zploskey commented Mar 14, 2018

Until the release we can test by bumping the dependency to puppeteer@next.

Archie Lee added some commits Mar 15, 2018

Archie Lee
Archie Lee

@zploskey zploskey merged commit c7831db into zploskey:master Mar 16, 2018

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details

@jihchi jihchi deleted the jihchi:bindings_for_contentFrame branch Mar 29, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment