Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upAdd BrowserFetcher bindings #42
Conversation
This comment has been minimized.
This comment has been minimized.
These look good to me. It's debatable whether we should bother typing the |
jihchi
force-pushed the
jihchi:40_bindings_for_browserfetcher
branch
from
dadad18
to
d69fa84
Mar 25, 2018
Mar 25, 2018
added some commits
zploskey
reviewed
Mar 25, 2018
src/BrowserFetcher.re
Outdated
| [@bs.as "mac"] `Mac | ||
| [@bs.as "linux"] `Linux | ||
| [@bs.as "win32"] `Win32 | ||
| [@bs.as "Win64"] `Win64 |
This comment has been minimized.
This comment has been minimized.
zploskey
Mar 25, 2018
Owner
win64 should be all lower case. If you just make the polymorphic variants all lower case and the same as the string doesn't it convert them to the right string? No need to use bs.as.
This comment has been minimized.
This comment has been minimized.
jihchi
Mar 26, 2018
Author
Collaborator
I thought variant constructor need to be capitalized. tried lower case but without success.
This comment has been minimized.
This comment has been minimized.
zploskey
Mar 26, 2018
Owner
Polymorphic variants don't need to be capitalized. For example: https://github.com/bs-puppeteer/bs-puppeteer/blob/master/src/ConsoleMessage.re
This comment has been minimized.
This comment has been minimized.
Mar 26, 2018
added some commits
This comment has been minimized.
This comment has been minimized.
Hi @zploskey , PR is done. |
zploskey
reviewed
Mar 26, 2018
src/Puppeteer.re
Outdated
}; | ||
|
||
[@bs.obj] | ||
external makeBrowserFetcherOption : |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
zploskey
merged commit cdd11a4
into
zploskey:master
Mar 26, 2018
1 check passed
continuous-integration/travis-ci/pr
The Travis CI build passed
Details
jihchi
deleted the
jihchi:40_bindings_for_browserfetcher
branch
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
jihchi commentedMar 19, 2018
•
edited
Fix #40
--
These bindings increase our unit test duration.
