New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tracing options and make Tracing.stop return a buffer #53

Merged
merged 3 commits into from Apr 13, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented Apr 13, 2018

Upgrades us to Puppeteer 1.3.
Fixes tracingOptions and its creation function.
Return a buffer from Tracing.stop().

Fixes #52.

zploskey added some commits Apr 13, 2018

Fix makeTracingOptions()
All the options should should be nullable in the type.
Wrap in a function that converts the bool to Js.boolean.

@zploskey zploskey merged commit faaf8c7 into master Apr 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the tracing_fixes branch Apr 13, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment