New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to bs-platform 3 and fix bool warnings #55

Merged
merged 1 commit into from May 5, 2018

Conversation

Projects
None yet
2 participants
@zploskey
Copy link
Owner

zploskey commented May 4, 2018

This allows us to eliminate a ton of boilerplate conversion since
BuckleScript bools are now represented by JS booleans under the
hood. This patch make a couple of changes across the codebase.

  • Convert all instances of Js.true_ to true and Js.boolean to bool.
  • Remove use of conversion functions like Js.Boolean.to_js_boolean.
  • Where wrapper functions only existed to convert between boolean
    representations, we remove the wrapper function.
  • Remove Util.optBoolToJs() and any wrapper functions that only
    served to apply that function to some of the arguments.

This eliminates all warnings when building with BS 3.0.0.

Upgrade to bs-platform 3 and fix bool warnings
This allows us to eliminate a ton of boilerplate conversion since
BuckleScript bools are now represented by JS booleans under the
hood. This patch make a couple of changes across the codebase.

- Convert all instances of Js.true_ to true and Js.boolean to bool.
- Remove use of conversion functions like Js.Boolean.to_js_boolean.
- Where wrapper functions only existed to convert between boolean
  representations, we remove the wrapper function.
- Remove Util.optBoolToJs() and any wrapper functions that only
  served to apply that function to some of the arguments.

This eliminates all warnings when building with BS 3.0.0.

@zploskey zploskey requested a review from jihchi May 4, 2018

@jihchi

jihchi approved these changes May 5, 2018

Copy link
Collaborator

jihchi left a comment

LGTM!

@zploskey zploskey merged commit 747b645 into master May 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the bs3 branch May 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment