New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Target.pageType to targetType #61

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented May 24, 2018

In fact only one of the targets is a page, so this is more
appropriately called targetType. I prefer this over using type_
with the underscore to avoid the reserved word, and this way it
does not use the same name as the type_ function.

Adds deprecations on pageType and its bs.deriving functions.

@zploskey zploskey force-pushed the targetType branch from b8d6618 to 29ae255 May 24, 2018

Rename Target.pageType to targetType
In fact only one of the targets is a page, so this is more
appropriately called targetType. I prefer this over using type_
with the underscore to avoid the reserved word, and this way it
does not use the same name as the type_ function.

Adds deprecations on pageType and its bs.deriving functions.

@zploskey zploskey force-pushed the targetType branch from 29ae255 to aa9f880 May 24, 2018

@zploskey zploskey merged commit 0c413ca into master May 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the targetType branch Jun 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment