New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add waitForRequest and waitForResponse functions #67

Merged
merged 1 commit into from Jul 25, 2018

Conversation

Projects
None yet
2 participants
@zploskey
Copy link
Owner

zploskey commented Jul 25, 2018

Adds the following functions to Page:

  • waitForRequest
  • waitForRequestRe
  • waitForRequestUrl
  • waitForResponse
  • waitForResponseRe
  • waitForResponseUrl

Adds one currently skipped test for waitForResponseUrl which won't pass until we run an HTTP server during the test run so that the fetch can succeed. Until then it demonstrates that it generates the right code.

Fixes #64.

waitForRequest and waitForResponse functions
Includes waitForRe*Url and waitForRe*Re for versions taking a URL
string or a function returning a regex object, respectively.

@zploskey zploskey requested a review from jihchi Jul 25, 2018

@jihchi

jihchi approved these changes Jul 25, 2018

Copy link
Collaborator

jihchi left a comment

LGTM

@zploskey zploskey merged commit 149749f into master Jul 25, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the waitForRequestResponse branch Jul 25, 2018

@zploskey

This comment has been minimized.

Copy link
Owner Author

zploskey commented Jul 25, 2018

Thanks for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment