New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FrameBase: add selectors / waitFor / XPath #7

Merged
merged 1 commit into from Feb 21, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented Feb 20, 2018

Fixes #5.

@zploskey

This comment has been minimized.

Copy link
Owner Author

zploskey commented Feb 20, 2018

@jihchi @Khady I'm open to suggestions on naming conventions here. The $ symbol is an infix operator in Reason so we have to use something else.

@zploskey zploskey force-pushed the selectors branch from 5fc4ba2 to 603e099 Feb 21, 2018

@zploskey

This comment has been minimized.

Copy link
Owner Author

zploskey commented Feb 21, 2018

I adjusted the function names and added a wrapper function for makeSelectorOptions that properly converts the bool values to Js.boolean.

@zploskey zploskey changed the title FrameBase: add querySelectors / waitFor / XPath FrameBase: add selectors / waitFor / XPath Feb 21, 2018

@zploskey zploskey merged commit c7ec94e into master Feb 21, 2018

@zploskey zploskey deleted the selectors branch Feb 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment