New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Page.viewport and Page.emulate #71

Merged
merged 2 commits into from Aug 4, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented Aug 4, 2018

Cleanup of code associated with the Page.viewport type.

  • Make all fields in viewport optional except for width and height.
  • Construct the viewport using bs.deriving abstract.
  • Introduce Page.Viewport module for this type.
  • Remove unnecessary unit argument to Page.viewport().
  • Rename Page.emulateOption to emulateOptions.

zploskey added some commits Aug 4, 2018

Fix Page.viewport and Page.emulate
Cleanup of code associated with the Page.viewport type.

- Make all fields in viewport optional except for width and height.
- Construct the viewport using bs.deriving abstract.
- Introduce Page.Viewport module for this type.
- Remove unnecessary unit argument to Page.viewport().
- Rename Page.emulateOption to emulateOptions.

@zploskey zploskey merged commit ff7cc18 into master Aug 4, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the viewportImprovements branch Aug 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment