New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add defaultViewport options and handle null viewports #73

Merged
merged 4 commits into from Aug 5, 2018

Conversation

Projects
None yet
1 participant
@zploskey
Copy link
Owner

zploskey commented Aug 5, 2018

Due to an upstream change (GoogleChrome/puppeteer@2563213), Page.viewport() can now be null, in which case it is disabled. Puppeteer.launch() now takes a defaultViewport option that can be set to null to disable the viewport by default.

Viewport has been promoted to top-level module since is now used outside of Page. Our Page.Viewport module was unreleased so this is not breaking and we maintain Page.viewport = Viewport.t.

zploskey added some commits Aug 5, 2018

Add defaultViewport option to connect + launch
In the process, make Viewport a top level module as it is now used in
Puppeteer and Page.

@zploskey zploskey merged commit df7c72e into master Aug 5, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@zploskey zploskey deleted the defaultViewport branch Aug 5, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment