--self-manage breaks usage of as:command

[mruwek]

• Type:
  • Bug
  • Enhancement
  • Feature Request
  • Question

---

Yep, I'm writing this from Cygwin, but the same bug is present on my Fedora25 linux machine (I'll update version strings accordingly when I'm back home).

• zplug --version: 2.4.1
• zsh --version: zsh 5.3 (x86_64-unknown-cygwin)
• uname -a: CYGWIN_NT-6.1 opti77 2.7.0(0.306/5/3) 2017-02-12 13:18 x86_64 Cygwi

Minimal zshrc (with less than 30 lines)

source ~/.zplug/init.zsh

zplug 'zplug/zplug', hook-build:'zplug --self-manage'
zplug "k4rthik/git-cal", as:command

if ! zplug check --verbose; then
  zplug install
fi

zplug load

Step to reproduce

1. Install zplug
2. Add config above
3. Reboot terminal and wait for installation to complete
4. Reboot terminal
5. git-cal
6. echo $ZPLUG_BIN
7. echo $PATH
8. ls $ZPLUG_BIN
9. ls $ZPLUG_HOME/repos/zplug/zplug/bin

Results

1. git-cal is not found.
2. $ZPLUG_BIN (/home/user/.zplug/bin by default) is different from relevant entry in the $PATH (/home/user/.zplug/repos/zplug/zplug/bin).
3. Relevant commands are properly installed in $ZPLUG_BIN.
4. $ZPLUG_HOME/repos/zplug/zplug/bin does not contain installed commands (git-cal in the example above).

[babarot]

Show me your zplug env

[mruwek]

@b4b4r07

Show me your zplug env

Here it is:

ZPLUG_ROOT = /home/jacek/.zplug/repos/zplug/zplug
ZPLUG_HOME = /home/jacek/.zplug
ZPLUG_THREADS = 16
ZPLUG_PROTOCOL = HTTPS
ZPLUG_FILTER = fzf-tmux:fzf:peco:percol:fzy:zaw
ZPLUG_LOADFILE = /home/jacek/.zplug/packages.zsh
ZPLUG_USE_CACHE = true
ZPLUG_ERROR_LOG = /home/jacek/.zplug/.error_log
ZPLUG_BIN = /home/jacek/.zplug/bin
ZPLUG_CACHE_DIR = /home/jacek/.zplug/cache
ZPLUG_REPOS = /home/jacek/.zplug/repos
_ZPLUG_VERSION = 2.4.1
_ZPLUG_URL = https://github.com/zplug/zplug
_ZPLUG_OHMYZSH = robbyrussell/oh-my-zsh
_ZPLUG_PREZTO = sorin-ionescu/prezto
_ZPLUG_AWKPATH = /home/jacek/.zplug/repos/zplug/zplug/misc/contrib
_ZPLUG_CONFIG_SUBSHELL = :

Also promised update of version strings:

• zplug --version: 2.4.1
• zsh --version: zsh 5.2 (x86_64-redhat-linux-gnu)
• uname -a: Linux srebrny-surfer 4.9.14-200.fc25.x86_64 Implement update command #1 SMP Mon Mar 13 19:26:40 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux

[mruwek]

Also as You can see I've probably found the source of the bug. Default value for ZPLUG_BIN was evaluated after the PATH was populated.

[mruwek]

Posted #389 with proposed fix.

[fbergroth]

Did you test #372? It should fix it as well, but the PR has been ignored so far.

[mruwek]

@fbergroth
No I didn't - I searched through issues, but not PRs (mea culpa!). I see now it's the same issue and quite similar approach to resolve it, only I've managed $ZPLUG_ROOT setting differently. Let's wait for the @b4b4r07 opinion about which solution he prefers.

[fbergroth]

@mruwek Your PR populates fpath with uninitialized variables. I cherrypicked your second commit into my branch, so hopefully #372 is a fix we can agree on.

[dieggsy]

For the record, I'm able to reproduce this exact issue.

[drrlvn]

For some reason #372 was closed but the fix there works.

[yacoob]

Just bumped into this: commands are linked in $ZPLUG_BIN, but it's $ZPLUG_ROOT/bin that's being added to PATH. Any chance for an upstream fix? :)

[babarot]

I'm gonna redesign --self-manage flag: #540 so closing this now.