A bunch of changes to support processing my data#6
Merged
Conversation
andreyvit
commented
Dec 27, 2011
andreyvit
commented
Contributor
- Input as a single array (-a, although potentially we could auto-detect)
- Running scripts via vm.runInNewContext, this allows deletion of keys (old approach did not work for that, somewhy)
- Fixed some existing bugs, which caused useless exceptions to be displayed when using -d
We're now using the vm module, so all four remaining users of v0.2 are out of luck now.
Owner
|
Hi Andrey, Thank you very much for your pull request! I am on vacation with my family right now, but I will look at your changes soon, and look forward to merging, and packaging them into the json npm module! Happy holidays! |
zpoley
added a commit
that referenced
this pull request
Dec 28, 2011
A bunch of changes to support processing my data
Owner
|
Hi Andrey, I published your changes in the npm package json@0.0.9. I left 0.0.8 in the npm registry for anyone tied to a node version behind 0.4. Thanks! Zach |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.