stop showing EPIPE#9
Merged
Merged
Conversation
Contributor
Author
|
This patch maybe fixes #5. $ node --version
v0.4.12
$ pwd
~/json_command
$ seq 1 10000 | ./bin/json.js | lessAnd exit pager: When this patch applied, this error is not occurred. |
Contributor
Author
|
Thanks for your merging ❤️ |
Owner
|
Thanks tricknotes! Great work. Merged and published in json@0.0.11. |
Contributor
Author
|
I'll install immediately 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
json-commandis a nice tool!Whenever I parse json, I use this awesome product.
But the following error occurred, when I give large buffer and use pager:
And close pager without reading all buffer:
The reason why this error occurred,
process.stdout.writethrow errorEPIPEwhen the pager(such asless,lv) closed before reading all buffer.I think that this case should not throw error.
Therefor, I stopped showing this error in the way to ignore
EPIPE.I tested my patch in the following node versions: