From 115d9ed280a3b2f937d9dccd818badb1523e3a3f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Geir=20G=C3=A5sodden?= Date: Mon, 28 Jun 2021 08:04:11 +0200 Subject: [PATCH] Changes var to const (patch) --- index.js | 12 ++++++------ lib/getHelpText.js | 2 +- test/lib/cli-test.js | 22 +++++++++++----------- test/lib/getHelpText-test.js | 6 +++--- 4 files changed, 21 insertions(+), 21 deletions(-) diff --git a/index.js b/index.js index 10db454..5626756 100755 --- a/index.js +++ b/index.js @@ -1,11 +1,11 @@ #!/usr/bin/env node -var pagespeed = require('gpagespeed') -var getHelpText = require('./lib/getHelpText') -var pkg = require('./package.json') -var query = process.argv[2] -var argv = require('minimist')((process.argv.slice(2))) -var options = {} +const pagespeed = require('gpagespeed') +const getHelpText = require('./lib/getHelpText') +const pkg = require('./package.json') +const query = process.argv[2] +const argv = require('minimist')((process.argv.slice(2))) +const options = {} if (!query || process.argv.indexOf('-h') !== -1 || process.argv.indexOf('--help') !== -1) { console.log(getHelpText()) diff --git a/lib/getHelpText.js b/lib/getHelpText.js index 88e284a..fe0914c 100644 --- a/lib/getHelpText.js +++ b/lib/getHelpText.js @@ -1,7 +1,7 @@ 'use strict' function getHelptext () { - var help = require('./helptext.json') + const help = require('./helptext.json') return help.join('\n') } diff --git a/test/lib/cli-test.js b/test/lib/cli-test.js index 0da7fca..374958c 100644 --- a/test/lib/cli-test.js +++ b/test/lib/cli-test.js @@ -1,9 +1,9 @@ 'use strict' -var exec = require('child_process').execFile -var tap = require('tap') -var getHelpText = require('../../lib/getHelpText') -var pkgVersion = require('../../package.json').version +const exec = require('child_process').execFile +const tap = require('tap') +const getHelpText = require('../../lib/getHelpText') +const pkgVersion = require('../../package.json').version tap.test('It returns helptext with -h flag', function helpTextWithH (test) { exec('./index.js', ['-h'], function getHelpTextWithH (error, stdout, stderr) { @@ -78,7 +78,7 @@ tap.test('It sets strategy if supplied', function testStrategy (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.strategy, 'mobile') test.end() }) @@ -89,7 +89,7 @@ tap.test('It sets locale if supplied', function testLocal (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.locale, 'no') test.end() }) @@ -100,7 +100,7 @@ tap.test('It sets screenshot if supplied', function testScreenshot (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.screenshot, true) test.end() }) @@ -111,7 +111,7 @@ tap.test('It sets filter_third_party_resources if supplied', function testThirdP if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.filter_third_party_resources, true) test.end() }) @@ -122,7 +122,7 @@ tap.test('It sets rule if supplied', function testRule (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.rule, 'goodrule') test.end() }) @@ -133,7 +133,7 @@ tap.test('It sets key if supplied', function testKey (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.key, 'opensesame') test.end() }) @@ -144,7 +144,7 @@ tap.test('It sets url if supplied', function testUrl (test) { if (error) { throw error } - var options = JSON.parse(stdout.toString().trim()) + const options = JSON.parse(stdout.toString().trim()) test.equal(options.url, 'http://www.google.com') test.end() }) diff --git a/test/lib/getHelpText-test.js b/test/lib/getHelpText-test.js index 141b2e1..d60bd0a 100644 --- a/test/lib/getHelpText-test.js +++ b/test/lib/getHelpText-test.js @@ -1,7 +1,7 @@ 'use strict' -var tap = require('tap') -var getHelpText = require('../../lib/getHelpText') -var helpText = require('../../lib/helptext.json').join('\n') +const tap = require('tap') +const getHelpText = require('../../lib/getHelpText') +const helpText = require('../../lib/helptext.json').join('\n') tap.equal(helpText, getHelpText(), 'It returns correct helptext')