Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upImprove overall plugins load performance #141
Conversation
This comment has been minimized.
This comment has been minimized.
Just a note, another way to get 50% improvement is to avoid using
After that I use simplified syntax of
|
This comment has been minimized.
This comment has been minimized.
I think they'll like to keep the old syntax. Regardless of that it's an alternative to the whole cache thing at #129. I'll try this later today. |
outcoldman
referenced this pull request
Jul 16, 2015
Closed
Starting zsh with antigen is very slow #116
This comment has been minimized.
This comment has been minimized.
@desyncr sure, it make sense, I don't want to change the syntax, this is why I just mentioned that it can be another way to improve performance. This pull request is only about avoiding unnecessary using We definitely need to fix |
This comment has been minimized.
This comment has been minimized.
forivall
commented
Jul 16, 2015
Just remember, desyncr isn't a contributor to antigen at all. I have a fixed version of antigen-parse-args in #132, but abandoned it because the maintainers seem to be absent, so I just switched to zgen. |
This comment has been minimized.
This comment has been minimized.
pushed a commit
to team-sonique/antigen
that referenced
this pull request
Jul 28, 2015
desyncr
referenced this pull request
Feb 13, 2016
Closed
antigen bundle and -antigen-ensure-repo taking too much time on cygwin #106
desyncr
self-assigned this
Jul 16, 2016
desyncr
added
the
Feature
label
Jul 16, 2016
This comment has been minimized.
This comment has been minimized.
Thank you @outcoldman for these changes. It has been merged. |
outcoldman commentedJul 16, 2015
-antigen-parse-args is very expensive. Avoiding using it in internal calls improve overall performance.
Instead of using -antigen-parse-args just invoke functions with arguments in expected order.
I got 50% performance improvement.