Conflicts with FZF (Tab does not show completion menu) and performance issues #108

Closed
balta2ar opened this Issue Feb 8, 2016 · 7 comments

4 participants

@balta2ar

Hello.

  • After I have updated zsh-autosuggestions to the latest version, Tab key is not showing me completion menu anymore. E.g. when I'm in the root (/), I do: % cd <Tab> and nothing happens. Here is (almost) minimal zshrc:
eval `dircolors -b`
bindkey -e
autoload -U compinit promptinit colors zstyle+ zmv 
zmodload -i zsh/complist
compinit
promptinit
colors

source ~/rc.arch/bz/thirdparty/zsh-autosuggestions/dist/autosuggestions.zsh
autosuggest_start

# I tried uncommenting these lines -- same result
# ZSH_AUTOSUGGEST_CLEAR_WIDGETS=("${(@)ZSH_AUTOSUGGEST_CLEAR_WIDGETS:#(up|down)-line-or-history}")
# ZSH_AUTOSUGGEST_CLEAR_WIDGETS+=(history-substring-search-up history-substring-search-down)

[ -f ~/.fzf.zsh ] && source ~/.fzf.zsh

fzf commit: 40d934e378ec2072c9d807f7ca1fca73bda1d13d
zsh-autosuggestions commit: f154d25

  • When I change directory in mc (midnight commander), I notice unusually high and irritating delay of about 400..500ms.

zsh version:

boltx64% zsh --version
zsh 5.2 (x86_64-unknown-linux-gnu)

OS: ArchLinux 4.3.3-2-ARCH x86_64

I tried putting autosuggest_start after fzf initialization and in plain terminal (terminator in my case) the effect is the same. In tmux, when I press Tab in such configuration, the session is simply closed as if I pressed C-d with no current input.

I've been using older version of fzf (several months old) and updated to the latest in hope that the problem will be fixed. It wasn't. I'm not sure which piece of software is playing wrong, but as there were recent substantial changes here, I'm reporting here. @ericfreese Could you look into this, please?

@adambiggs

+1 I'm also having this problem.

@adambiggs adambiggs added a commit to adambiggs/dotfiles that referenced this issue Feb 9, 2016
@adambiggs adambiggs fix(zsh): `zsh-autosuggestions` conflicts with `fzf` shell integration
Temporarily disabled on the `fzf` side while keeping an eye on zsh-users/zsh-autosuggestions#108.
f085dd8
@DannyNemer

I also have this issue.

@ericfreese
zsh-users member

I believe v0.2.6 should fix this issue. Please give that a shot.

Edit: v0.2.6 had a typo. Try v0.2.7

@ericfreese ericfreese closed this Feb 15, 2016
@balta2ar

@ericfreese Thank you for your work, it indeed fixes the first of my issues! However, the second remains. I still have significant delay when changing directory in mc. Could there anything be done about that?

@ericfreese
zsh-users member

Good! Can you add a separate issue for that (with as much info as possible to reproduce that specific problem)?

@adambiggs

Fixed for me, thanks! 🍻

@DannyNemer

Fixed! Thank you for your excellent work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment