install script emits bad characters on cygwin #46

Closed
apjanke opened this Issue Mar 4, 2015 · 1 comment

3 participants

@apjanke

The install script has a cosmetic issue when running on Cygwin/Windows 7 for me. The \n characters are printed literally instead of turning in to newlines, even when explicitly run under bash.

install on cygwin-win7 under mintty

This is on Windows 7, with Cygwin updated as of about 1/25/2015.

$ uname -a
CYGWIN_NT-6.1 gwydion 1.7.34(0.285/5/3) 2015-02-04 12:14 x86_64 Cygwin

I think this is because echo is non-portable when used with escape sequences or options. Different shells and even different bashes might behave differently on different systems. Described here. It'll probably affect Fedora 21 and FreeBSD as well, based on a similar issue I've seen with oh-my-zsh (robbyrussell/oh-my-zsh#3658).

Looks like it could be fixed by replacing echo with printf calls.

@apjanke apjanke changed the title from install outputs bad characters on cygwin to install script emits bad characters on cygwin Mar 4, 2015
@faceleg faceleg added the bug label Mar 4, 2015
@jirutka

I recommend to just not use this installation script and copy those few lines manually according to new instructions in the readme.

@faceleg faceleg closed this May 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment