bindkey "^I" is not overrided #64

Closed
Alessandro-Barbieri opened this Issue May 24, 2015 · 13 comments

4 participants

@Alessandro-Barbieri

We know from #14 that "^I" should not be bind to zprezto expand-or-complete-with-indicator.
From sorin-ionescu/prezto#884
An override can be added in order to avoid commenting these lines?
https://github.com/sorin-ionescu/prezto/blob/a84ac5b0023d71c98bb28a68c550dc13f6c51945/modules/editor/init.zsh#L303-L304

@faceleg faceleg added the bug label Jun 7, 2015
@faceleg

Would you PR?

@Alessandro-Barbieri

PR is pull request?

I try to explain better the issue:
if I put
bindkey -r "^I"
inside .zshrc (or at the last line)
it complains that bindkey: no such keymap `'

if I type in in the terminal, it works

@sorin-ionescu
zsh-users member

I can add this override in Prezto when I add zsh-autosuggestions as an external module unless you think it's better for zsh-autosuggestions to handle it since there are others who may have completion indicators.

@ericfreese
zsh-users member

There's a rewrite underway in PR #91. It's available on branch v0.1.x. Please try using that branch, and let me know if it solves your problem.

@Alessandro-Barbieri

I still have the same problem

@ericfreese
zsh-users member

Thanks for checking.

I'm having some trouble understanding exactly what the issue is here (I'm not very familiar with zprezto, and only started using this plugin myself a few weeks ago).

What exactly are you trying to accomplish? What problem are you running in to? How can I reproduce it?

Thanks

@ericfreese ericfreese added this to the v0.1.0 milestone Jan 29, 2016
@Alessandro-Barbieri

What exactly are you trying to accomplish?

To run zprezto and zsh autosuggestions at the same time

What problem are you running in to?

Tab removes the previous line

How can I reproduce it?

Just install zprezo and zsh-autosuggestions (I think is enough)

@ericfreese
zsh-users member

Just install zprezo and zsh-autosuggestions (I think is enough)

I will try this tomorrow and see if I can reproduce.

In the mean time, I just pushed a fix to autocomplete (#73) that may solve the problem. You might update again and see if the problem is solved by that.

@ericfreese ericfreese modified the milestone: v0.1.1, v0.1.0 Feb 7, 2016
@ericfreese
zsh-users member

I believe this is a bug in zprezto. These lines should use the builtin dot-prefixed version of those widgets or use the -w flag to set $WIDGET and related variables correctly. See the discussion on this here. I believe the right fix in this case is to use the dot-prefixed versions of those widgets.

cc @sorin-ionescu Thoughts?

@ericfreese
zsh-users member

I believe v0.2.7 should fix all of these issues without requiring changes to other plugins. Please give that a shot @Alessandro-Barbieri

@ericfreese ericfreese closed this Feb 15, 2016
@Alessandro-Barbieri

I still have this problem.

@ericfreese
zsh-users member

I still have this problem.

Can you confirm that this problem, reported in this issue (#64), is now fixed?

Are you now saying you're having a separate issue? If so, can you please create a new issue with a minimal .zshrc and clear steps to reproduce the problem? The code has changed so much since the issue you linked was created, I doubt much of that discussion is still relevant.

@Alessandro-Barbieri

Nevermind, I was still using the old method to run zsh-autosuggestions. #14 and #64 are fixed for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment