Restore standard widgets to fix segfault when re-sourcing autosuggestions.zsh #85
+52
−49
faceleg
commented
Jan 20, 2016
Have the installation / usage instructions changed as well?
What I mean to say is, I want to use this IMMEDIATELY, what do I need to know?
Have the installation / usage instructions changed as well?
They shouldn't have changed. It should just work as it did before, but with less segfaults.
But you know, I'm playing with it now, and it definitely seems broken... Maybe not ready to merge just yet.
After working on ericfreese/zsh-autosuggestions though, I'm personally inclined to just go that route instead of messing with fixing this.
faceleg
commented
Jan 20, 2016
If you're saying it is more broken than it was before - I don't believe you.
Want to paste your fork on top of this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Adds
$ZLE_AUTOSUGGEST_ALL_WIDGETSarray which groupsself-insert,magic-space,backward-delete-char, andaccept-linewith other widget arrays for easy looping.Removes all references to
autosuggest-*-origwidgets in favor of the '.'-prefixed names (i.e..self-insertinstead ofautosuggest-self-insert-orig)Extracts widget setup code to two new functions:
autosuggest-hook-widgetsandautosuggest-restore-widgetsCalls
autosuggest-restore-widgetswhen sourced to fix issue #84.Tested locally with zsh 5.0.7 and 5.2.