Clean up #87

Closed
wants to merge 1 commit into
from

3 participants

@ericfreese
zsh-users member

Rewriting a lot of code for improved stability.

  • Using POSTDISPLAY instead of LBUFFER and RBUFFER.
  • Removing pause/suspend/resume state management code.
  • Removing unused server/client code.

See issue #86.

TODO

  • Remove suggestion (POSTDISPLAY) on ctrl-c. [Not sure how to do this. Ideas?]
  • Fix syntax highlight coloring.
  • Display suggestion again after navigating history.
    • After pressing up and then down, should display the same autosuggestion it originally did.
  • Multi-line support
  • support for overriding user-defined widgets (like history-substring-search-up/down)
@faceleg

Such wow

@faceleg faceleg added the enhancement label Jan 20, 2016
@faceleg

@tarruda can @ericfreese please have collaborator access?

@tarruda

@ericfreese added as collaborator, thanks for the contributions

@faceleg

Thank you @tarruda! And thanks for neovim :) been using it daily for many many months.

@ericfreese
zsh-users member

Thanks @tarruda

It's in a pretty stable place now with syntax highlighting working. Would be great if you could pull it down and play around with it. I'm going to be out of town through the end of the weekend, but should be able to get back to this next week.

@faceleg

I'll install it and report back if anything goes crazy

@ericfreese
zsh-users member

I'd like to go ahead and merge this into master. It's looking pretty solid to me. Any objections?

I was planning to keep the current master branch available via a separate branch so people can always use the current version if necessary.

@ericfreese ericfreese referenced this pull request Jan 27, 2016
Merged

Cleanup #91

6 of 7 tasks complete
@ericfreese
zsh-users member

Closed. See PR #91.

@ericfreese ericfreese closed this Jan 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment