Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests fail on msys2 #382

Closed
danielshahaf opened this issue Oct 19, 2016 · 0 comments · Fixed by #453
Closed

Tests fail on msys2 #382

danielshahaf opened this issue Oct 19, 2016 · 0 comments · Fixed by #453
Labels
Task
Milestone
0.7.0

Comments

@danielshahaf
Copy link
Member

https://gist.github.com/trapd00r/5586ef14b9d108ac439c4cdde9f19909

option-path_dirs fails because chmod +x is a no-op.

path-broken-symlink fails because ln -s is an alias for cp (and the test deliberately creates a broken symlink).

The tests should be fixed to either PASS or SKIP.

(Reported by @trapd00r.)
phy1729 added a commit to phy1729/zsh-syntax-highlighting that referenced this issue Nov 6, 2017
@phy1729
'main': Skip tests that break on msys2
749b302 
Closes zsh-users#382.
@phy1729 phy1729 mentioned this issue Nov 6, 2017
Merged
brandon-fryslie pushed a commit to brandon-fryslie/zsh-syntax-highlighting that referenced this issue Dec 21, 2017
@phy1729 @brandon-fryslie
'main': Skip tests that break on msys2
ba063b3 
Closes zsh-users#382.
@phy1729 phy1729 added this to the 0.7.0 milestone Dec 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Task
Projects
None yet
Milestone
0.7.0
Development

Successfully merging a pull request may close this issue.

Add ability to skip tests phy1729/zsh-syntax-highlighting
2 participants
@phy1729 @danielshahaf