Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Doesn't send `before_send` signal if `ContactView` is subclassed #18

Closed
akaihola opened this Issue · 0 comments

2 participants

@akaihola

In ContactView.form_valid(), the before_send signal is sent while specifying self.__class__ as the sender. In case of subclasses, __class__ is the subclass instead of ContactView.

The signal handler is only connected to the ContactView base class, so subclasses fail to send the signal.

Maybe ContactView should be specified as the sender when sending the signal instead?

A work-around is to register the signal for the subclass as well.

@zsiciarz zsiciarz referenced this issue from a commit
@zsiciarz Test case for issue #18. 73767fa
@zsiciarz zsiciarz closed this in 3a02888
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.