/lifeguard

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trait implementations for `Recycled` #15

Closed
jonhoo opened this Issue Jul 5, 2016 · 2 comments

Comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@jonhoo @zslayton
@jonhoo

jonhoo commented Jul 5, 2016

Currently, Recycled doesn't forward very many traits, even if the underlying type implements them. In particular, fairly standard traits such as Clone, PartialOrd or Hash are inaccessible through Recycled and RcRecycled. This makes the wrapper type much harder to work with, and is pretty easy to fix. The impls section of Rc provides a fairly good list of traits that it's good for wrapper types to proxy.
@zslayton

This comment has been minimized.

Sign in to view
Owner

zslayton commented Jul 31, 2016

This is a great idea. Unfortunately, I don't have time to implement it at the moment. PRs are welcome if you have the time!

@zslayton zslayton closed this in 5bd809b Nov 13, 2018

@zslayton

This comment has been minimized.

Sign in to view
Owner

zslayton commented Nov 13, 2018

The fix for this added implementations for:

  • PartialEq
  • Eq
  • PartialOrd
  • Ord
  • Hash
  • Clone

PRs forwarding other traits from std are welcome.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment