diff --git a/com.zsmartsystems.zigbee.console/src/main/java/com/zsmartsystems/zigbee/console/ZigBeeConsoleOtaUpgradeCommand.java b/com.zsmartsystems.zigbee.console/src/main/java/com/zsmartsystems/zigbee/console/ZigBeeConsoleOtaUpgradeCommand.java index fa50ef379f..5ad2701487 100644 --- a/com.zsmartsystems.zigbee.console/src/main/java/com/zsmartsystems/zigbee/console/ZigBeeConsoleOtaUpgradeCommand.java +++ b/com.zsmartsystems.zigbee.console/src/main/java/com/zsmartsystems/zigbee/console/ZigBeeConsoleOtaUpgradeCommand.java @@ -133,10 +133,16 @@ private void cmdDisplayAllNodes(ZigBeeNetworkManager networkManager, PrintStream private void cmdDisplayNode(ZigBeeEndpoint endpoint, ZclOtaUpgradeServer otaServer, PrintStream out) { Object fileVersion = otaServer.getCurrentFileVersion(); + String fileVersionAsStr; + if (fileVersion instanceof Integer) { + fileVersionAsStr = String.format("%08X", ((Integer) fileVersion).intValue()); + } else { + fileVersionAsStr = "Unknown"; + } out.println("OTA Upgrade configuration for " + endpoint.getEndpointAddress()); out.println("Current state : " + otaServer.getServerStatus()); - out.println("Firmware Version : " + (fileVersion == null ? "Unknown" : String.format("%08X", fileVersion))); + out.println("Firmware Version : " + fileVersionAsStr); } private Map getApplications(ZigBeeNetworkManager networkManager, int clusterId) { diff --git a/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/network/impl/CommandInterfaceImpl.java b/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/network/impl/CommandInterfaceImpl.java index 9f9f881981..488ab23c7f 100644 --- a/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/network/impl/CommandInterfaceImpl.java +++ b/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/network/impl/CommandInterfaceImpl.java @@ -242,7 +242,7 @@ public void sendSynchronousCommand(final ZToolPacket packet, final SynchronousCo if (supportMultipleSynchrounsCommand) { synchronized (synchronousCommandListeners) { final short id = (short) (cmdId.get16BitValue() & 0x1FFF); - while (synchronousCommandListeners.get(cmdId) != null) { + while (synchronousCommandListeners.get(id) != null) { try { logger.trace("Waiting for other request {} to complete", id); synchronousCommandListeners.wait(500); diff --git a/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/zigbee/util/ZToolAddress64.java b/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/zigbee/util/ZToolAddress64.java index 0c7235e2d4..334fc7e065 100644 --- a/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/zigbee/util/ZToolAddress64.java +++ b/com.zsmartsystems.zigbee.dongle.cc2531/src/main/java/com/zsmartsystems/zigbee/dongle/cc2531/zigbee/util/ZToolAddress64.java @@ -33,7 +33,6 @@ package com.zsmartsystems.zigbee.dongle.cc2531.zigbee.util; import java.util.Arrays; -import java.util.Objects; /** * Big Endian container for 64-bit XBee Address @@ -78,7 +77,7 @@ public void setAddress(byte[] address) { @Override public int hashCode() { - return Objects.hash(address); + return Arrays.hashCode(address); } @Override diff --git a/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/groups/ZigBeeGroup.java b/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/groups/ZigBeeGroup.java index 9517decb6e..65641ad998 100644 --- a/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/groups/ZigBeeGroup.java +++ b/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/groups/ZigBeeGroup.java @@ -38,7 +38,7 @@ * * @author Chris Jackson */ -public class ZigBeeGroup implements Comparable { +public class ZigBeeGroup implements Comparable { static final int MAX_LABEL_LENGTH = 16; static final int GROUP_ID_MIN = 0x0000; @@ -365,7 +365,7 @@ public int hashCode() { } @Override - public int compareTo(Object that) { + public int compareTo(ZigBeeGroup that) { if (this == that) { return 0; } diff --git a/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/zcl/field/ZclArrayList.java b/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/zcl/field/ZclArrayList.java index 30879d76c8..ca7276841e 100644 --- a/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/zcl/field/ZclArrayList.java +++ b/com.zsmartsystems.zigbee/src/main/java/com/zsmartsystems/zigbee/zcl/field/ZclArrayList.java @@ -144,12 +144,12 @@ public void add(int index, Object element) { @Override public Object remove(int index) { - return remove(index); + return list.remove(index); } @Override public int indexOf(Object o) { - return indexOf(o); + return list.indexOf(o); } @Override diff --git a/pom.xml b/pom.xml index db74ea61e5..e1d414f4cd 100644 --- a/pom.xml +++ b/pom.xml @@ -39,11 +39,14 @@ 2023 + 1.8 + 1.8 UTF-8 UTF-8 1.7.30 1.2.17 1.23 + 2.10.0 @@ -126,6 +129,11 @@ + + org.apache.maven.plugins + maven-compiler-plugin + 3.8.0 + @@ -133,10 +141,9 @@ org.apache.maven.plugins maven-compiler-plugin - 3.8.0 - 1.8 - 1.8 + ${source.version} + ${target.version} -Xpkginfo:always @@ -345,6 +352,49 @@ + + + error-prone-check + + + [11,16) + + + + + org.apache.maven.plugins + maven-compiler-plugin + + ${source.version} + ${target.version} + ${project.build.sourceEncoding} + + -XDcompilePolicy=simple + -Xplugin:ErrorProne + + true + + + com.google.errorprone + error_prone_core + ${error-prone.version} + + + + + + + +