Remove unnecessary tests #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, I left the auto-generated test classes there exactly to remind me that real tests should be written. Absolutely. I'm really not sure though how to approach testing the gradle plugin. Any ideas? |
|
@vanniktech any further input please? |
|
Not yet. I'd say we first work on 1.2 and then add some tests since 1.2 breaks more or less the api. Also I'd then refer to the two issues you created. We shouldn't use this PR anymore. On 3 January 2016 22:45:45 CET, Zsolt Kocsi notifications@github.com wrote:
Sent from my Android device with K-9 Mail. Please excuse my brevity. |
|
Agreed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They're not really adding any value.
Do you plan to write some tests for the core functionality though (Java API and Gradle Plugin)?