This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add redis stream #16
Add redis stream #16
Changes from 32 commits
2e2350a
2b16d69
621a557
c11dd63
ccc309f
dfcbfcf
ffb7ce3
cf3c955
6a7cc38
c8183a6
b9b9da6
8db3939
ba75cd2
5116b0b
0b90931
fba38a8
22b499a
6047a19
6e2dd20
b2d4a50
4b68d47
689a581
64eeca9
005cd70
5a513d9
2af4f96
3689190
3de4c48
5bb71a6
3147511
3fedeed
ba8ae70
0dca6c5
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update:ok
est ignoré non? pourquoi mettre une valeur ici?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
peu importe oui
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pourquoi tu passes pas le timeout directement en argumetn de cette fonction? C'est la fonction parente qui a le plus de connaissance sur quel timeout mettre
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ya pas un mode autoack sur aioredis?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
euh aucune idée jvais regarder
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tu peux pas merge api/api/constants.py et celui là? si tu mets les mêmes valeurs..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bah ca veut dire que les subprojects worker et api sont dépendants, a terme peut etre gérer ça avec des variables d'environnements spécifiés dans les Dockerfile ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oui tu peux, ou laisse comme ça.si tu as une bonne raison c'est pas grave
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
je note ca quelque part ca sera modifié sur la partie mise en prod