Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fine-grained websocket close handshake API #481

Merged
merged 29 commits into from Mar 12, 2019

Conversation

@kachayev
Copy link
Collaborator

kachayev commented Feb 9, 2019

Quick note. This functionality has a lot of merge conflicts with #422.

Covers #470 and #478.

@ztellman The only one thing I have doubts about... I had to update netty/sink to "close" itself when receiving a specific message, here. Should I just use .markClosed or I need to call (s/close! this)? All attempts to reimplement this without "self-closing" led to potential race conditions, so I choose this approach as the most reasonable.

@kachayev

This comment has been minimized.

Copy link
Collaborator Author

kachayev commented Feb 22, 2019

Merged with the latest master to avoid conflicts. Part of this functionality is still not implemented tho' because it's intertwined with another PR.

@kachayev kachayev changed the title [WIP] Fine-grained websocket close handshake API Fine-grained websocket close handshake API Feb 23, 2019
@ztellman ztellman merged commit 06f14d5 into ztellman:master Mar 12, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.