Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

100-Continue handler #482

Merged
merged 8 commits into from May 14, 2019
Merged

100-Continue handler #482

merged 8 commits into from May 14, 2019

Conversation

@kachayev
Copy link
Collaborator

kachayev commented Feb 9, 2019

Covers #462.

Without any additional configuration works the same way as before (using an instance of HttpServerExpectContinueHandler).

When provided, :continue-handler will be invoked with ring request w/o :body. It should respond with

  • true to accept the request
  • false to reject with a default "417 Expectation Failed" response
  • ring response to reject message with the response provided
  • deferred that yields one of those

By default will be executed on the response-executor or on custom continue-executor. :none might be used to execute the handler inlined.

Note, that introducing "Expect: 100-continue" flow support for the client is pretty problematic as for now. Maybe it should be handled by Netty's HttpClientCodec but I need to do more experiments with the implementation.

@ztellman ztellman merged commit 927226a into ztellman:master May 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.