Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http/file API to send region of the file #485

merged 16 commits into from Apr 19, 2019


Copy link

kachayev commented Feb 11, 2019

Quick note. This PR clashes with #471 almost entirely. So.. Either #471 should be merged first, so I can reimplement the current one, or this one should be merged first, so I can reimplement #471.

Covers #469. The key motivation factor is byte range requests.

Now I can send as a body:

  • java.nio.file.Path
  • (aleph.http/file path)
  • (aleph.http/file path offset length)

It also extends API so I can set custom chunk size.

(.-offset file)
(.-length file))))

(defn new-http-file

This comment has been minimized.

Copy link

ztellman Mar 25, 2019


This should just be http-file.

This comment has been minimized.

Copy link

kachayev Mar 26, 2019

Author Collaborator


@ztellman ztellman merged commit 28f931a into ztellman:master Apr 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
2 participants
You can’t perform that action at this time.