Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show the channel when printing `AlephServer` object #491

Merged
merged 1 commit into from Mar 25, 2019

Conversation

@kachayev
Copy link
Collaborator

kachayev commented Feb 23, 2019

Tiny operational improvement. Now you can actually see Netty's channel, address, port, and the transport used.

user> (def server (http/start-server (fn [_] {:status 200 :body "OK"}) {:port 2020}))
server
user> server
#object[aleph.netty$start_server$reify__53226 0x5f495e42 "AlephServer[channel:[id: 0x75644268, L:/0:0:0:0:0:0:0:0:2020], transport::nio]"]

We can even go further and implement print-method but AlephServer does not expose the underlying channel. And I don't want to extend the protocol just to deal with printing.

@ztellman ztellman merged commit 94a3871 into ztellman:master Mar 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.