Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WebSocket connection to expose more information about handshake result #498

Merged
merged 7 commits into from Mar 25, 2019

Conversation

@kachayev
Copy link
Collaborator

kachayev commented Mar 24, 2019

When working with different subprotocols you need to have access to the result of the handshaking negotiation. Response headers are also captured for the client, e.g. to deal with situations like #494.

I've also reverted back some changes I did a long time ago regarding WebSocket client handshake processing. Previously I thought that the old approach leads to leaks, but that was a wrong assumption.

@ztellman ztellman merged commit a74dba8 into ztellman:master Mar 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.