Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accurate processing for proxy connection exception #509

Merged
merged 1 commit into from May 14, 2019

Conversation

@kachayev
Copy link
Collaborator

kachayev commented May 4, 2019

The previous implementation throws ProxyConnectionTimeoutException in case of any proxy connection error. Which is obviously misleading. The fix provided is capable of dealing with 3 different types of exceptions:

  • connection timeout
  • HTTP proxy exception with input headers attached (introduced here)
  • generic connection exception (e.g. "disconnect", "no response" etc)
@ztellman ztellman merged commit 5cc7bca into ztellman:master May 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.