Make _isShutdown volatile
#30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's read/written by different threads (particularly, it's read by the daemon thread defined in the Pool constructor). Because access to the variable isn't guarded by a synchronized block or the `volatile` modifier, there isn't a visibility guarantee across threads. This would be a reasonable explanation for a thread leak I'm experiencing.
|
@vemv Did making it |
|
I think that I had an additional fix for an unrelated thing and that between both, dirigiste behaved better. |
|
I see no immediate errors in the tests of dirigiste, manifold, or aleph, so I'm merging. |
|
Thanks! 🍻 Yes, volatile only adds safety, it is extremely unlikely that it would make code incorrect. |
|
Yeah, but you never know when something depends on a bug... 😭 I would like to sunset Dirigiste, it seems to be flaky. We keep getting hard-to-reproduce OOM issues. If Loom/virtualThreads pan out, I may remove the Dirigiste executors entirely from Aleph/Manifold, and replace the connection pooling with something more battle-tested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's read/written by different threads (particularly, it's read by the daemon thread defined in the Pool constructor).
Because access to the variable isn't guarded by a synchronized block or the
volatilemodifier, there isn't a visibility guarantee across threads.This would be a reasonable explanation for a thread leak I'm experiencing.