Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Reflection warnings #8

Merged
merged 2 commits into from

2 participants

@amalloy

Fixed a couple reflection warnings in gloss. I also fixed some on lamina master, before I realized you're probably only interested in those on the perf branch (or possibly clj-1.3?). Let me know if you'd like those after all.

Also, might it be good to make perf be the default lamina branch on github? That would have prevented me wasting effort on a branch that doesn't matter, but it might also imply that a "not yet ready" branch is the one people should be using, so I'm happy to hear that I just should have paid more attention to which branch I was working on.

@ztellman ztellman merged commit 4640947 into ztellman:clj-1.3
@ztellman
Owner

Thanks for this. I've updated the lamina repo to point at clj-1.3, with the intention of pointing it to the perf branch once I have a little more documentation in place. I'll take the blame for the wasted effort, sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Mar 27, 2012
  1. @amalloy

    Fix reflection warning

    amalloy authored
  2. @amalloy

    Fix loop autobox warning

    amalloy authored
This page is out of date. Refresh to see the latest.
Showing with 3 additions and 2 deletions.
  1. +1 −1  src/gloss/data/bytes/core.clj
  2. +2 −1  src/gloss/data/primitives.clj
View
2  src/gloss/data/bytes/core.clj
@@ -170,7 +170,7 @@
(if (>= offset n)
(ByteBuffer/wrap ary)
(let [buf ^ByteBuffer (first bytes)
- num-bytes (min (.remaining buf) (- n offset))]
+ num-bytes (long (min (.remaining buf) (- n offset)))]
(-> buf duplicate (.get ary offset num-bytes))
(recur (+ offset num-bytes) (rest bytes))))))))))
View
3  src/gloss/data/primitives.clj
@@ -47,7 +47,8 @@
(defn long->ulong
[x]
- (bigint (BigInteger. 1 (long->byte-array x))))
+ (let [^bytes magnitude (long->byte-array x)]
+ (bigint (BigInteger. 1 magnitude))))
(defn ubyte->byte
[x]
Something went wrong with that request. Please try again.