fix related to options arity change #36

Merged
merged 1 commit into from May 7, 2012

Projects

None yet

2 participants

@mpenet
Contributor
mpenet commented May 7, 2012

related to mpenet@d6e5c0c

It seems it wasn't complete, I had arity exceptions showing up caused by it (through aleph.redis):

for instance:

Exception in thread "main" clojure.lang.ArityException: Wrong number of args (11) passed to: instrument$instrument
    at clojure.lang.AFn.throwArity(AFn.java:437)
    at clojure.lang.AFn.invoke(AFn.java:84)
    at clojure.lang.AFn.applyToHelper(AFn.java:235)
    at clojure.lang.AFn.applyTo(AFn.java:151)
    at clojure.core$apply.invoke(core.clj:603)
    at lamina.connections$try_instrument.invoke(connections.clj:145)
    at lamina.connections$pipelined_client.invoke(connections.clj:290)
    at aleph.redis$redis_client.invoke(redis.clj:75)
    at qualia.store.redis$eval14626$fn__14627.invoke(redis.clj:70)
    at clojure.lang.MultiFn.invoke(MultiFn.java:163)
    at qualia.test.core$eval14723.invoke(core.clj:55)
    at clojure.lang.Compiler.eval(Compiler.java:6511)
    at clojure.lang.Compiler.eval(Compiler.java:6501)
    at clojure.lang.Compiler.load(Compiler.java:6952)
    at clojure.lang.RT.loadResourceScript(RT.java:359)
    at clojure.lang.RT.loadResourceScript(RT.java:350)
    at clojure.lang.RT.load(RT.java:429)
    at clojure.lang.RT.load(RT.java:400)
    at clojure.core$load$fn__4890.invoke(core.clj:5415)
    at clojure.core$load.doInvoke(core.clj:5414)
    at clojure.lang.RestFn.invoke(RestFn.java:408)
    at clojure.core$load_one.invoke(core.clj:5227)
    at clojure.core$load_lib.doInvoke(core.clj:5264)
    at clojure.lang.RestFn.applyTo(RestFn.java:142)
    at clojure.core$apply.invoke(core.clj:603)
    at clojure.core$load_libs.doInvoke(core.clj:5298)
    at clojure.lang.RestFn.applyTo(RestFn.java:137)
    at clojure.core$apply.invoke(core.clj:603)
    at clojure.core$require.doInvoke(core.clj:5381)
    at clojure.lang.RestFn.invoke(RestFn.java:421)
    at user$eval29.invoke(NO_SOURCE_FILE:1)
    at clojure.lang.Compiler.eval(Compiler.java:6511)
    at clojure.lang.Compiler.eval(Compiler.java:6501)
    at clojure.lang.Compiler.eval(Compiler.java:6477)
    at clojure.core$eval.invoke(core.clj:2797)
    at clojure.main$eval_opt.invoke(main.clj:297)
    at clojure.main$initialize.invoke(main.clj:316)
    at clojure.main$null_opt.invoke(main.clj:349)
    at clojure.main$main.doInvoke(main.clj:427)
    at clojure.lang.RestFn.invoke(RestFn.java:421)
    at clojure.lang.Var.invoke(Var.java:419)
    at clojure.lang.AFn.applyToHelper(AFn.java:163)
    at clojure.lang.Var.applyTo(Var.java:532)
    at clojure.main.main(main.java:37)

I am not 100% confident this is what you intended here (whole maps vs unrolled maps) but it fixes my issue for now.

Max

@ztellman
Owner
ztellman commented May 7, 2012

Yikes. I realized that the code wasn't consistent w.r.t. unrolled maps, and since there's already some prior art on Aleph using whole maps, I decided to standardize on that. Apparently didn't catch all of them, thanks.

@ztellman ztellman merged commit 2aed627 into ztellman:perf May 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment