This repository has been archived by the owner on Nov 9, 2017. It is now read-only.
Compatibility with lein1 and lein2 #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing its changes to project.clj overwritten by a subtask lein2 merges and unmerges profiles in a difficult-to-discover way, which is why dependencies must either be injected directly at eval-in-project, or else this extra work with profile management must be done.
|
Leinjacker 0.3.0 has been released, so the portable hook-eval-in-project functionality can be used in a deployed version. I've also written some code to safely include the injection in the project map, so that it works with lein2 profiles. For now, I'm using similar code in guzheng to ensure that modifications to the project map persist through arbitrary subtask chaining. Ultimately, this could be added to leinjacker, which would then make lein-sleight lein1 and lein2 compatible. I think that these changes are suitable for merging, as they don't change any existing behavior, but they pave the way for lein1 and lein2 portability. |
ztellman
added a commit
that referenced
this pull request
Oct 3, 2012
Compatibility with lein1 and lein2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made a couple changes that depend on the yet-to-be-released version of leinjacker (tentatively 0.3.0-SNAPSHOT). This should allow sleight to work on lein1 and lein2. Take a look, and as soon as leinjacker gets released, hopefully these changes can go in to sleight.