New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Q3 player brandon's hat does not render #175

Closed
zturtleman opened this Issue Feb 19, 2014 · 2 comments

Comments

2 participants
@zturtleman
Owner

zturtleman commented Feb 19, 2014

Both Spearmint and ioquake3 show a warning when loading the brandon player.

WARNING: R_FindImageFile could not find 'models/players/light/brandon/branhat.glow.tga' in shader 'models/players/brandon/branhat'
Shader models/players/brandon/branhat has a stage with no image

ioquake3 uses shader_t * from R_FindShader internally (which does not get set to tr.defaultShader).

Spearmint uses qhandle_t from trap_R_RegisterShaderEx (which get set to 0 for defaultShader).

mint-arena makes shader handle 0 invisible to be compatible with Q3 not rendering missing shaders, when that is disabled it shows default image.

ioquake3 developer mode spams the following each frame;

WARNING: no shader for surface h_hat in skin models/players/brandon/head_default.skin

This is a data issue.

  • Solution A) add image or change the shader.
  • Solution B) ???

@zturtleman zturtleman added the bug label Feb 19, 2014

@zturtleman

This comment has been minimized.

Show comment
Hide comment
@zturtleman

zturtleman Feb 19, 2014

Owner

Fixed in zturtleman/spearmint-patch-data@4494ae6 by adding a 2x2 black image. (Gets rid of warnings in ioq3 too.)

Owner

zturtleman commented Feb 19, 2014

Fixed in zturtleman/spearmint-patch-data@4494ae6 by adding a 2x2 black image. (Gets rid of warnings in ioq3 too.)

@zturtleman zturtleman closed this Feb 19, 2014

zturtleman referenced this issue in zturtleman/spearmint-patch-data Feb 19, 2014

Add missing image for brandon's hat shader
Add black 2x2 image that is referenced by "models/players/brandon/branhat" shader.

Fixes warning in ioq3 and Spearmint.
Fixes drawing in Spearmint (0 handle is returned to VM, ioq3 uses internal pointer to real shader).
@coltongit

This comment has been minimized.

Show comment
Hide comment
@coltongit

coltongit Jul 2, 2016

Fixing the models.shader present in the original Q3 files allows this problem to permanently go away.

coltongit commented Jul 2, 2016

Fixing the models.shader present in the original Q3 files allows this problem to permanently go away.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment