Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid nil package resource name for pkg_php_mbstring #3

Merged
merged 1 commit into from Mar 10, 2014

Conversation

Projects
None yet
2 participants
@chrludwig
Copy link
Contributor

chrludwig commented Mar 10, 2014

As reported in issue #2, the nil value in pkg_php_mbstring makes postfixadmin-cookbook's default recipe fail for me with an error message that package resource names must not be nil.

This patch always assigns a non-nil name to the package resource and specifies the package name via the package_name resource attribute. This way the not_if guard becomes effective.

Regards
Christoph

zuazo added a commit that referenced this pull request Mar 10, 2014

Merge pull request #3 from chrludwig/master
avoid nil package resource name for pkg_php_mbstring

@zuazo zuazo merged commit b2bf0ab into zuazo:master Mar 10, 2014

@zuazo

This comment has been minimized.

Copy link
Owner

zuazo commented Mar 10, 2014

@chrludwig, thanks for the fix. Merged.

@zuazo

This comment has been minimized.

Copy link
Owner

zuazo commented Mar 16, 2014

Released in version 0.1.3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.